Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(builder): use a3p config for emerynet in mintHolder proposal #11087

Draft
wants to merge 1 commit into
base: dev-upgrade-19
Choose a base branch
from

Conversation

mujahidkay
Copy link
Member

@mujahidkay mujahidkay commented Mar 6, 2025

closes: #XXXX
refs: #XXXX

Description

Since we recently respun emerynet from a3p, some of the variant configs need updating. In u19, packages/builders/scripts/vats/upgrade-mintHolder.js needs the same labelList as a3p because that is what emerynet's current state is representative of.

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

Only needed for emerynet verification (the sdk image) so no obligations to merge this PR (yet)

@mujahidkay mujahidkay self-assigned this Mar 6, 2025
@mujahidkay mujahidkay changed the base branch from master to dev-upgrade-19 March 6, 2025 12:37
@mujahidkay mujahidkay added the force:integration Force integration tests to run on PR label Mar 6, 2025
Copy link

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0d0f319
Status: ✅  Deploy successful!
Preview URL: https://5caf14cc.agoric-sdk.pages.dev
Branch Preview URL: https://mk-emerynet-patch.agoric-sdk.pages.dev

View logs

Copy link
Member

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve approach in principle. Feel free to manually trigger a docker image build from this branch in GH Actions.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants