Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(swingset): add exit/vatstore syscalls to non-local vat workers #2645

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

warner
Copy link
Member

@warner warner commented Mar 15, 2021

Some unfortunate code duplication meant the nodeworker/subprocess-node
workers were lacking vatstoreGet, vatstoreSet, and vatstoreDelete. And
everything but the local worker was lacking syscall.exit.

refs #2643 , but doesn't close it because I want to (eventually) write proper
tests for this

cc @dckc just so you know this is getting addressed :)

Some unfortunate code duplication meant the nodeworker/subprocess-node
workers were lacking vatstoreGet, vatstoreSet, and vatstoreDelete. And
everything but the local worker was lacking syscall.exit.

refs #2643 , but doesn't close it because I want to (eventually) write proper
tests for this
@warner warner added the SwingSet package: SwingSet label Mar 15, 2021
@warner warner requested a review from FUDCo March 15, 2021 15:49
@warner warner self-assigned this Mar 15, 2021
Copy link
Contributor

@FUDCo FUDCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Longer term, there's a lot of code that is replicated across the various vat worker implementations that probably should be refactored to only exist in one place.

@warner warner enabled auto-merge (rebase) March 15, 2021 16:18
@warner warner merged commit 35fceb1 into master Mar 15, 2021
@warner warner deleted the 2643-exit-vatstore-workers branch March 15, 2021 16:34
gibson042 added a commit that referenced this pull request Dec 3, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
SwingSet package: SwingSet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants