Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: keyField issue for class instances, fix #770 #771

Merged
merged 1 commit into from
Dec 14, 2022
Merged

fix: keyField issue for class instances, fix #770 #771

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vue-virtual-scroller/src/components/DynamicScrollerItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export default {
id () {
if (this.vscrollData.simpleArray) return this.index
// eslint-disable-next-line no-prototype-builtins
if (this.item.hasOwnProperty(this.vscrollData.keyField)) return this.item[this.vscrollData.keyField]
if (this.vscrollData.keyField in this.item) return this.item[this.vscrollData.keyField]
throw new Error(`keyField '${this.vscrollData.keyField}' not found in your item. You should set a valid keyField prop on your Scroller`)
},

Expand Down