Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix completion handler cache image setting #20

Closed
wants to merge 2 commits into from
Closed

Fix completion handler cache image setting #20

wants to merge 2 commits into from

Conversation

kcharwood
Copy link
Contributor

Fixed an issue from the following conditions:

  • Image was in the cache
  • A completion handler was provided to the image view

Before the fix, the image would not be set. After the fix, the image is now properly set, even if you provide a completion handler.

@kcharwood kcharwood added the bug label Sep 23, 2015
@kcharwood kcharwood added this to the 1.1.2 milestone Sep 23, 2015
@cnoon
Copy link
Member

cnoon commented Sep 26, 2015

Thanks for this @kcharwood! I merged in your changes in 4da49ab and b056b3c.

@cnoon cnoon closed this Sep 26, 2015
@cnoon cnoon self-assigned this Sep 26, 2015
@cnoon
Copy link
Member

cnoon commented Sep 26, 2015

I'll push this out in the 1.1.2 release here shortly.

@cnoon cnoon deleted the fix_completion_handler_cache_image_setting branch September 26, 2015 21:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@cnoon cnoon

Labels
bug
Projects
None yet
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@kcharwood @cnoon