Issue 323: Caching fails with custom SessionManager #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apter modifying the url Fix by caching the image keyed by the original request instead of the adapted one.
|
Hi @graphiclife, thank you for putting this together. I think it would be wise to instead support a custom cache key like you have done in #324. I'm going to go ahead and close this PR out in favor of that approach. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 323: Caching fails with custom SessionManager with a request adapter modifying the url
Fix by caching the image keyed by the original request instead of the adapted one.
Issue Link 🔗
Caching fails with custom SessionManager with a request adapter modifying the url #323