This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
Write OptionAnswer value to non interface{} map #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@coryb @AlecAivazis Could you please review this PR, and suggest changes if any? |
|
Hey @infixint943! Would you mind writing a test that covers this change? I am having a hard time following the exact situation you are trying to address. |
|
@AlecAivazis I have added tests. |
|
Any updates @AlecAivazis? |
AlecAivazis
approved these changes
Aug 10, 2020
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Basically, the commit enables to write just the string value (or index) of an option selected in
survey.Select{}to a map ofstrings/ints. This is achieved by passing amap[string]stringormap[string]intinstead ofmap[string]interface{}.Also, thanks a lot for this wonderful package!