Improved multiple Linux modules #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. mount.cifs can use pass= instead of password= and cred= can alternatively be used to specify a credential file. Continue on empty lines because the line.split() call resulted in ValueError: not enough values to unpack (expected 6, got 0)
It could be confusing when searching multiple user's keyrings as root. Additionally, ordered the output keys more intuitively.
- check for read access instead of being root; permissions could be misconfigured - skip !! hashes, they are disabled on RHEL-like systems - more intuitive output ordering - removed outdated comment about SHA-512 being used on all modern computers (yescrypt it is)
|
Thanks a lot for your PR ! 👍🏼 |
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some small improvements in the Linux modules
fstab,libsecret,env_variableandshadow. The individual commit messages describe what I changed and why.Please let me know if this is fine or whether I should change something.
(Besides, I have a question not related to the PR: I noticed that (at least) the wallet modules require the
dbus-pythonpackage but it is not listed inrequirements.txt. Is this on purpose? Maybe because building it depends oncmakeanddbus-python-develsystem packages? Though in general I would have expected that this is included inrequirements.txt. Should I add it?)