Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add slather/Coveralls test coverage reports #17

Merged
merged 3 commits into from
Apr 23, 2015
Merged

Add slather/Coveralls test coverage reports #17

merged 3 commits into from
Apr 23, 2015

Conversation

dasmer
Copy link
Contributor

@dasmer dasmer commented Apr 21, 2015

  • Modify project file to generate code coverage metrics
  • Add step to .travis.yml to install slather and send metrics to Coveralls
  • Add .slather.yml to configure how we send metrics to Coveralls.
  • Add Coveralls Badge to README.md

You will need to enable Coveralls for AlexDenisov/FrameAccessor. I ran slather locally and reported test coverage is 100% 🌟

@AlexDenisov
Copy link
Owner

Very nice feature, thank you @dasmer.
I didn't manage to find why coveralls needs commit access, maybe you can give me a point?
I'm pretty sure there is something obvious, but I can't blindly give an access to a third-party tool, 'cause I'm member of a few organizations with a bunch of private repos.

@dasmer
Copy link
Contributor Author

dasmer commented Apr 21, 2015

@AlexDenisov I would refer to lemurheavy/coveralls-public#450. I believe Coveralls needs commit:status to generate coverage stats. I would defer to @nickmerwin for more info.

@dasmer
Copy link
Contributor Author

dasmer commented Apr 21, 2015

It looks like test coverage isn't being reported correctly on Travis. Closing until I figure out why.

@dasmer dasmer closed this Apr 21, 2015
@AlexDenisov
Copy link
Owner

Got it, let me know if I can help you.

@dasmer
Copy link
Contributor Author

dasmer commented Apr 23, 2015

Re-opening to test a fix

@dasmer dasmer reopened this Apr 23, 2015
Install activesupport on travis

Remove coverage option
@dasmer
Copy link
Contributor Author

dasmer commented Apr 23, 2015

@AlexDenisov: We're getting coverage reports now 💃

Coverage Status

@dasmer
Copy link
Contributor Author

dasmer commented Apr 23, 2015

Also, to give you some more insight on why coveralls.io asks for commit read access, the service gives you line-by-line data on how often a tested line is called on in your unit tests:

ie:
screen shot 2015-04-22 at 10 06 12 pm

AlexDenisov added a commit that referenced this pull request Apr 23, 2015
Add slather/Coveralls test coverage reports
@AlexDenisov AlexDenisov merged commit 4537452 into AlexDenisov:master Apr 23, 2015
@AlexDenisov
Copy link
Owner

Great job, @dasmer!
Waiting for a travis build to see the new and shiny coveralls badge 👍

@MaximDzhezhelo
Copy link

Very good job)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants