Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DPL: read metadata from parent files #13665

Merged
merged 5 commits into from
Nov 7, 2024
Merged

DPL: read metadata from parent files #13665

merged 5 commits into from
Nov 7, 2024

Conversation

ktf
Copy link
Member

@ktf ktf commented Nov 7, 2024

If the metadata is not found in the main file and if there is a
list of parent files, try those as well.

Stack created with Sapling. Best reviewed with ReviewStack.

@ktf ktf requested a review from a team as a code owner November 7, 2024 12:19
Copy link
Contributor

github-actions bot commented Nov 7, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

This way a plugin can create more complex AlgorithmSpecs which depend on
the workflow options. This will be needed to properly read metadata from
parent files, and it opens the way to more service devices to be moved
in a plugin.
If the metadata is not found in the main file and if there is a
list of parent files, try those as well.
@ktf ktf merged commit 2c1efe4 into AliceO2Group:dev Nov 7, 2024
5 of 6 checks passed
@ktf
Copy link
Member Author

ktf commented Nov 7, 2024

This was also validated on hyperloop (both by me and by @fgrosa) and locally by myself. Merging.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant