Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enforces packaging of eggs into folders. #22

Merged
merged 1 commit into from
Jul 19, 2018
Merged

Conversation

hfjn
Copy link

@hfjn hfjn commented May 29, 2018

We had an error in our CI pipeline where a package build would fail since the .egg of stop-words is downloaded as a zip.

This leads to the following error where the initializer tries to open a directory when it is actually a zip archive.

Not a directory: '/opt/project/.eggs/stop_words-2015.2.23.1-py3.6.egg/stop_words/stop-words/languages.json'

Fixes resolving of errors in following build pipelines.
@Alir3z4
Copy link
Owner

Alir3z4 commented May 29, 2018

@hfjn Thanks for the patch.
Could you please look into the TravisCI and see fix the build fail ?

@hfjn
Copy link
Author

hfjn commented May 29, 2018

@Alir3z4 I'd like to but there seems to be an error in your pipeline.

Getting distribution for 'pbp.recipe.noserunner==0.2.6'.
Couldn't find index page for 'pbp.recipe.noserunner' (maybe misspelled?)

Got the feeling that you have a problem with setuptools, maybe regarding to the new pypi version?

@Alir3z4
Copy link
Owner

Alir3z4 commented May 29, 2018

Interesting.
Let me have a look at the setup and packages

@Alir3z4
Copy link
Owner

Alir3z4 commented May 29, 2018

@hfjn
Copy link
Author

hfjn commented May 29, 2018

@Alir3z4 Jep. But this seems to be the current one. https://pypi.org/project/pbp.recipe.noserunner/

@Alir3z4
Copy link
Owner

Alir3z4 commented May 29, 2018

Yes, that's why I'm confused, It exists.
hmmm...

@Alir3z4
Copy link
Owner

Alir3z4 commented Jun 25, 2018

@Fantomas42 any idea how we can fix this ?
I check all the version seems to be correct and I double check them with other projects with the same setup, all seems to be correct.

I appreciate it if you could have a look at let us know how we can fix this.

@Laubeee
Copy link
Contributor

Laubeee commented Jul 19, 2018

Hm my PR has obviously the same issue. After quick research i found this thread: buildout/buildout#420

jamadden: "Do you perhaps have a custom index URL specified for PyPI? Or are you using a version of zc.buildout older than 2.9.5? If so, you will probably need to manually specify the URL to be HTTPS instead of HTTP. PyPI recently disabled all API support for HTTP."

pretty sure this is it (u're using zc.buildout 2.3.1.). Either upgrade it or specify the URL as suggested above

@Alir3z4
Copy link
Owner

Alir3z4 commented Jul 19, 2018

@Laubeee Excellent finding, thank you for sharing it.
I made the pull request #24 and to see if it fixed the problem. Let see how it goes.

Once, fixed we can merge and publish new release

@Alir3z4 Alir3z4 self-assigned this Jul 19, 2018
@Alir3z4
Copy link
Owner

Alir3z4 commented Jul 19, 2018

Thanks for the contribution and great help.
I will merge and will cut a release soon, by today or tomorrow.

@Alir3z4 Alir3z4 merged commit 407a441 into Alir3z4:master Jul 19, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants