Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

No other play should be allowed after "no advance" situation #242

Closed
3 of 4 tasks
AloisSeckar opened this issue Jul 15, 2024 · 1 comment
Closed
3 of 4 tasks

No other play should be allowed after "no advance" situation #242

AloisSeckar opened this issue Jul 15, 2024 · 1 comment
Labels
1.2 target Issues aimed for 1.2 release bug Something isn't working

Comments

@AloisSeckar
Copy link
Owner

AloisSeckar commented Jul 15, 2024

It works in v1.1, was not covered via #217 yet.

Although it is technically possible to have a "no advance" situation (error) and then some other play, allowing it would raise an undefined number of clashing situation that would require separate validations.

Eg.:
image

Also it is not possible to have "no advance" at they some play at 2nd base, only at 3rd:
image

For now the solution is to disable this completely. We may think of white-listing certain combinations if they prove necessary later.

  • update GUI components to disallow selecting extra input after "no advance" situation
  • check list of "NoAdvanceSituations" in wbsc-validation.ts
  • add info in "Limitations" section
  • update checkNoAdvances validation comment
@AloisSeckar AloisSeckar added bug Something isn't working 1.2 target Issues aimed for 1.2 release labels Jul 15, 2024
@AloisSeckar
Copy link
Owner Author

fixed with b733166

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
1.2 target Issues aimed for 1.2 release bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant