-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix missing legacy lineage panel. #1431
Fix missing legacy lineage panel. #1431
Conversation
WalkthroughThe changes in the Changes
Possibly related issues
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files not reviewed due to no reviewable changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 9c53f05 in 6 seconds
More details
- Looked at
12
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. .vscodeignore:14
- Draft comment:
Ensure that removinglineage_panel
from the ignore list does not unintentionally include other files that should remain excluded. This change aligns with the intent to include thelineage_panel
directory in the build package. - Reason this comment was not posted:
Confidence changes required:50%
The change in the .vscodeignore file is correct as it aligns with the intent to include the lineage_panel directory in the build package. However, the PR description mentions that the intent behind the previous change was not thoroughly investigated. It would be prudent to ensure that this change does not unintentionally include other files that should remain excluded.
Workflow ID: wflow_xUXwbCmSJHCP6ec8
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Releasing for now but the panel will be deprecated soon |
Overview
Problem
#1430 The legacy LINEAGE panel is not displayed.
The extension runtime detects an uncaught error:
This issue is caused by the
.vscodeignore
excluding thelineage_panel
directory from the build package.Solution
The solution is to modify the
.vscodeignore
to include thelineage_panel
directory in the build package.NOTE:
.vscodeignore
was modified in #1410, but the intent behind this change has not been thoroughly investigated.Screenshot/Demo
How to test
Rebuild and install the updated extension package.
Verify that the legacy LINEAGE panel is displayed correctly.
Checklist
README.md
updated and added information about my changeImportant
Fix missing legacy LINEAGE panel by including
lineage_panel
in the build package.lineage_panel
directory in the build package..vscodeignore
to removelineage_panel
from the exclusion list.This description was created by
for 9c53f05. It will automatically update as commits are pushed.
Summary by CodeRabbit
.vscodeignore
file to replacelineage_panel
withnew_lineage_panel
, ensuring the new panel is properly recognized in the development environment.