Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix missing legacy lineage panel. #1431

Merged

Conversation

solavrc
Copy link
Contributor

@solavrc solavrc commented Sep 21, 2024

Overview

Problem

#1430 The legacy LINEAGE panel is not displayed.

The extension runtime detects an uncaught error:

ENOENT: no such file or directory, open '/home/vscode/.vscode-server/extensions/innoverio.vscode-dbt-power-user-0.45.1/lineage_panel/index.html'

This issue is caused by the .vscodeignore excluding the lineage_panel directory from the build package.

Solution

The solution is to modify the .vscodeignore to include the lineage_panel directory in the build package.

NOTE: .vscodeignore was modified in #1410, but the intent behind this change has not been thoroughly investigated.

Screenshot/Demo

How to test

Rebuild and install the updated extension package.
Verify that the legacy LINEAGE panel is displayed correctly.

Checklist

  • I have run this code and it appears to resolve the stated issue
  • README.md updated and added information about my change

Important

Fix missing legacy LINEAGE panel by including lineage_panel in the build package.

  • Bug Fix:
    • Fix missing legacy LINEAGE panel by including lineage_panel directory in the build package.
    • Modify .vscodeignore to remove lineage_panel from the exclusion list.

This description was created by Ellipsis for 9c53f05. It will automatically update as commits are pushed.

Summary by CodeRabbit

  • Chores
    • Updated the .vscodeignore file to replace lineage_panel with new_lineage_panel, ensuring the new panel is properly recognized in the development environment.

Copy link
Contributor

coderabbitai bot commented Sep 21, 2024

Walkthrough

The changes in the .vscodeignore file involve the removal of the entry for lineage_panel and the addition of a new entry for new_lineage_panel. This indicates a transition from ignoring the legacy lineage panel files to focusing on the new lineage panel files, while maintaining the inclusion of the dist directory within new_lineage_panel.

Changes

File Change Summary
.vscodeignore Removed entry lineage_panel, added entry new_lineage_panel, kept !new_lineage_panel/dist unchanged.

Possibly related issues


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b810e1c and 9c53f05.

Files selected for processing (1)
  • .vscodeignore (0 hunks)
Files not reviewed due to no reviewable changes (1)
  • .vscodeignore

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 9c53f05 in 6 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .vscodeignore:14
  • Draft comment:
    Ensure that removing lineage_panel from the ignore list does not unintentionally include other files that should remain excluded. This change aligns with the intent to include the lineage_panel directory in the build package.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change in the .vscodeignore file is correct as it aligns with the intent to include the lineage_panel directory in the build package. However, the PR description mentions that the intent behind the previous change was not thoroughly investigated. It would be prudent to ensure that this change does not unintentionally include other files that should remain excluded.

Workflow ID: wflow_xUXwbCmSJHCP6ec8


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@anandgupta42
Copy link
Contributor

Releasing for now but the panel will be deprecated soon

@anandgupta42 anandgupta42 merged commit 03ecc60 into AltimateAI:master Sep 23, 2024
7 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Sep 24, 2024
2 tasks
@coderabbitai coderabbitai bot mentioned this pull request Nov 13, 2024
2 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants