Fix seeds defnition provider

[mdesmet]

Overview

Problem

Describe the problem you are solving. Mention the ticket/issue if applicable.

Solution

Describe the implemented solution. Add external references if needed.

Screenshot/Demo

A picture is worth a thousand words. Please highlight the changes if applicable.

How to test

• Steps to be followed to verify the solution or code changes
• Mention if there is any settings configuration added/changed/deleted

Checklist

• I have run this code and it appears to resolve the stated issue
• README.md updated and added information about my change

---

Important

Fixes model name extraction in NodeParser by using path.parse(fullPath).name.

• Behavior:
  • Fixes model name extraction in NodeParser by using path.parse(fullPath).name instead of basename(fullPath, ".sql").
• Misc:
  • No changes to settings or configurations.
  • No updates to README.md.

^{This description was created by for 1e34168. It will automatically update as commits are pushed.}

Summary by CodeRabbit

• Refactor
  • Updated method for extracting file base names in node parsing logic
  • Improved path name extraction mechanism

[coderabbitai]

Walkthrough

The pull request introduces a minor modification in the createNodeMetaMap method of the NodeParser class within the src/manifest/parsers/nodeParser.ts file. The change involves updating the method for extracting the base name of a file path from using basename() to path.parse().name. This alteration may impact how model names are derived and stored in the modelNameLookupMap.

Changes

File	Change Summary
src/manifest/parsers/nodeParser.ts	Modified file name extraction method in createNodeMetaMap from basename(fullPath, ".sql") to path.parse(fullPath).name

Suggested Reviewers

• saravmajestic

Note: No sequence diagram was generated as the changes are minimal and do not significantly alter the control flow or introduce a new feature.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cf52e7f and 1e34168.

📒 Files selected for processing (1)

• src/manifest/parsers/nodeParser.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: build (windows-latest)
• GitHub Check: Analyze (python)
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (1)

src/manifest/parsers/nodeParser.ts (1)

102-102: Good improvement using path.parse().name for extension-agnostic model names.

The change from basename(fullPath, ".sql") to path.parse(fullPath).name makes the code more generic by supporting any file extension, not just ".sql" files.

Let's verify DBT's file extension support and potential impact:

Consider adding tests:
Would you like me to help create test cases to verify the behavior with different file extensions?

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 1e34168 in 22 seconds

More details

• Looked at 13 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. src/manifest/parsers/nodeParser.ts:102

• Draft comment:
  Good change to use 'path.parse(fullPath).name' instead of 'basename(fullPath, ".sql")'. This makes the code more robust to changes in file extensions.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The change from 'basename(fullPath, ".sql")' to 'path.parse(fullPath).name' is correct and improves the code by removing the dependency on the file extension. This makes the code more robust to changes in file extensions.

2. src/manifest/parsers/nodeParser.ts:105

• Draft comment:
  Use semantic versioning (semver) for version comparisons instead of direct array index manipulation for better accuracy and readability.
• Reason this comment was not posted:
  Comment was on unchanged code.

Workflow ID: wflow_8ZqRRkbUot7mkAQJ

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.