Do not load thumbnails strip at controller creation #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 17, 2017 22:15
We can just check if the `UINavigationBar` is hidden or not.
# Conflicts: # Sources/Classes/PDFViewController.swift
…repare`, obviously)
stuffmc
force-pushed
the
feature/disable_thumbnails
branch
from
7bf8f64 to
8f8ec07
Compare
stuffmc
changed the title
stuffmc
changed the title
stuffmc
changed the title
ranunez
reviewed
Feb 23, 2017
| @@ -55,6 +55,8 @@ internal final class StartViewController: UIViewController { | |||
| /// Presents a document | |||
| /// | |||
| /// - parameter document: document to present | |||
| /// | |||
| /// Add `thumbnailsEnabled:false` to `createNew` to not load the thumbnails in the controller. | |||
There was a problem hiding this comment.
Please update the README with this new flag instead of this comment
ranunez
reviewed
Feb 23, 2017
| @@ -17,7 +17,7 @@ extension PDFViewController { | |||
| /// - parameter backButton: button to override the default controller back button | |||
| /// | |||
| /// - returns: a `PDFViewController` | |||
| public class func createNew(with document: PDFDocument, title: String? = nil, actionButtonImage: UIImage? = nil, actionStyle: ActionStyle = .print, backButton: UIBarButtonItem? = nil) -> PDFViewController { | |||
| public class func createNew(with document: PDFDocument, title: String? = nil, actionButtonImage: UIImage? = nil, actionStyle: ActionStyle = .print, backButton: UIBarButtonItem? = nil, thumbnailsEnabled: Bool? = true) -> PDFViewController { | |||
There was a problem hiding this comment.
Why is thumbnailsEnabled here optional? If its not optional, we wouldn't need to force unwrap it below (it should still have a default value)
There was a problem hiding this comment.
Also, please update the documentation with this new parameter
ranunez
reviewed
Feb 23, 2017
| } | ||
|
|
||
| /// Slides horizontally (from left to right, default) or vertically (from top to bottom) | ||
| public var scrollDirection: UICollectionViewScrollDirection = .horizontal { |
There was a problem hiding this comment.
I think this is supposed to be in #40 instead
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some apps (like ours) don't want to display the thumbnails. In our case, most documents are 1 to 2 pages, so it doesn't make sense. Also, this way it doesn't have to load an additional controller.