-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
revisit data-* attributes #96
Comments
Current list of data- attributes added in html output
|
Let's also fix |
For |
The main work has been merged. Let's test and see. |
Visual regression tests showed no problems. The only unexpected change were found in bproc34, mcom3351, mcom3354, mcom3358 which have I consider this an unexpected fix. |
All fixed. |
As we have moved away from htmlbook as a dependency, we should revisit the data attributes.
Some ideas
data-type="chapter"
)data-ams
, alternativelydata-jats
to reduce changes in ams-html)Note: this originates in the mkb-hill3 QA report which suggests replacing
data-type="chapter"
withepub:type="chapter"
. This is not strictly necessary since in our workflow each file is exactly one chapter and epub3 specifies that in lieu ofepub:type="chapter"
and similar markup that's acceptable. If we do something, I'd rather adopt the dpub aria roles here (which epub will adopt in the future).The text was updated successfully, but these errors were encountered: