Add ability to unset an array. Closes #45 #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine! @pgilad thanks for all your contributions so far, great work! :) |
|
No problem... I want to see Ampersand succeeding 🏆 |
|
+1. Array.isArray is IE9+ for those wondering. |
|
Isn't Object.defineProperty IE9+ as well, so basically that is the par line? I can rebase this with |
|
Nope! IE9 is our base target, was just confirming that this doesn't change anything in re our requirements. Thanks for the mountain of PRs you sent in the last few days! |
|
No problem 😄 |
wraithgar
pushed a commit
that referenced
this pull request
Mar 31, 2015
Add ability to unset an array. Closes #45
|
published as |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.