poc: Add bottom margin to text components #1903
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
Links to full-screen pages
Why
To make it easy for our users to apply space in prose consistently.
How
:has
selector to let the bottom margin of a component depend on the component that follows it. This is as designed, logical, and prevents the use of:last-child
which is error-prone for this context.xl
space from 48 to 56 and added anxxl
of 84, both according to the design. This could be the start of merging Component Space and Grid Space, although both currently shrink and grow quite differently.Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes
This generates quite a few lines of CSS, but I see no way around it. We must use our classes and explicitly address all combinations. The built stylesheet increased from 99 to 103 kB, so I guess around 1 kB per component that uses this.
Then this would create all the selectors to add space between all kinds of headings and all kinds of body text: