Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add patch to remove capitalization of DISTRIBUTION_NAME #9

Merged
merged 8 commits into from
Jan 23, 2023

Conversation

marcoesters
Copy link
Contributor

@marcoesters marcoesters commented Jan 19, 2023

Restore old Miniconda behavior by adding the installation directory to prompt name.

Jira ticket: https://anaconda.atlassian.net/browse/PKG-1010

Copy link

@pseudoyim pseudoyim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@marcoesters marcoesters merged commit 9aa74c2 into master Jan 23, 2023
@marcoesters marcoesters deleted the menuinst branch January 23, 2023 19:07
@jaimergp
Copy link

jaimergp commented Aug 30, 2023

Hey folks, I am taking a look at how conda-forge's conda-standalone differs from defaults', and this PR is one of the differences. Is this a critical patch? Can you provide more details about why is it needed? We could release a new menuinst (1.4.20) with this patch if needed.

edit - posted more stuff in #11

@marcoesters
Copy link
Contributor Author

This patch is the result of customer complaints that the prompt had changed. When we still operated on different forks, this was a difference and after merging, customers didn't like the change, so we removed the assumption that we want to capitalize the name.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants