Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove separate serde_derive imports from doc tests. #23

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

Anders429
Copy link
Owner

serde currently recommends to use the derive feature and not depend on serde_derive directly (although this recommendation may change, see discussion in serde-rs/serde#2584). Therefore, this library should also not recommend using serde_derive directly either, so as not to create confusion.

Additionally, this has the benefit of shortening the doc-test examples.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (93966f1) 98.23% compared to head (1872cb8) 98.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #23   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files           3        3           
  Lines        6571     6571           
=======================================
  Hits         6455     6455           
  Misses        116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Anders429 Anders429 merged commit f07486f into dev Dec 18, 2023
@Anders429 Anders429 deleted the serde_derive branch December 18, 2023 21:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant