fix: return empty string for empty attributes (“”, ‘’)

Signed-off-by: Andreas Pizsa <hopster@gmail.com>
AndreasPizsa · Mar 17, 2022 · 44288f3 · 44288f3
1 parent 53d8b8e
commit 44288f3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/hypertag.js b/hypertag.js
@@ -40,7 +40,11 @@ function parseAttrs(htmlTagText, tagKey = '<') {
   while ((match = matchPattern.exec(htmlTagText)) !== null) {
     const key = match[1]
     attrs[key]
-      = (match[5] !== null && match[5]) || (match[3] !== null && match[3]) || true
+    = match[5] !== undefined
+        ? match[5]
+        : (match[3] !== undefined
+          ? match[3]
+          : true)
   }
   return attrs
 }

diff --git a/test/test.js b/test/test.js
@@ -65,6 +65,9 @@ test('attributes', t => {
     <${randomTagName} ${randomAttr}= "${randomValue}">
     <${randomTagName} ${randomAttr} ='${randomValue}'>
     <${randomTagName} ${randomAttr} =  ${randomValue}>
+    <${randomTagName} emptyTag      =  "">
+    <${randomTagName} emptyTag      =  ''>
+    <${randomTagName} emptyTag      =  >
     <${randomTagName}
       ${randomAttr} = ${randomValue}>
     <${randomTagName} ${randomAttr}
@@ -77,6 +80,9 @@ test('attributes', t => {
     {[tagKey]: randomTagName, [randomAttr]: randomValue},
     {[tagKey]: randomTagName, [randomAttr]: randomValue},
     {[tagKey]: randomTagName, [randomAttr]: randomValue},
+    {[tagKey]: randomTagName, emptyTag: ''},
+    {[tagKey]: randomTagName, emptyTag: ''},
+    {[tagKey]: randomTagName, emptyTag: true},
     {[tagKey]: randomTagName, [randomAttr]: randomValue},
     {[tagKey]: randomTagName, [randomAttr]: randomValue}
   ])