fix: stripComments bug that caused infinite loop

AndreasPizsa · Mar 8, 2022 · dbd9819 · dbd9819
1 parent 8f128d9
commit dbd9819
Show file tree

Hide file tree

Showing 3 changed files with 217 additions and 1 deletion.
diff --git a/hypertag.js b/hypertag.js
@@ -47,5 +47,5 @@ function parseAttrs(htmlTagText, tagKey = '<') {
 
 function stripComments(html) {
   // eslint-disable-next-line unicorn/better-regex
-  return html.replace(/<!--([\s]|.)*?-->/gims, '')
+  return html.replace(/<!--[\s\S]*?(?:-->)/gms, '')
 }
diff --git a/test/fixture-qualcomm.html b/test/fixture-qualcomm.html
diff --git a/test/qualcomm.test.js b/test/qualcomm.test.js
@@ -0,0 +1,15 @@
+const {readFileSync} = require('node:fs')
+const {resolve} = require('node:path')
+const test = require('ava')
+const parse = require('../hypertag.js')
+const {stripComments} = require('../hypertag.js')
+
+const html = readFileSync(resolve(__dirname, './fixture-qualcomm.html'), 'utf-8')
+
+test('it can strip comments from developer.qualcomm.com', t => {
+  t.notThrows(() => stripComments(html))
+})
+
+test('it can parse developer.qualcomm.com', t => {
+  t.notThrows(() => parse(html))
+})