Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updating changelog and more optional ndim #411

Merged
merged 6 commits into from
May 31, 2021

Conversation

AndrewAnnex
Copy link
Owner

preparing for 4.0.1 release, also saw a lot of ndim's to make optional and updated test_wrapper to use a autouse pytest fixture to reduce some duplication of kclear calls

@pep8speaks
Copy link

pep8speaks commented May 31, 2021

Hello @AndrewAnnex! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Comment last updated at 2021-05-31 15:24:16 UTC

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #411 (354bb60) into main (dca3b8a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
- Coverage   99.88%   99.87%   -0.01%     
==========================================
  Files          12       12              
  Lines       15206    14731     -475     
==========================================
- Hits        15188    14713     -475     
  Misses         18       18              
Impacted Files Coverage Δ
spiceypy/tests/test_wrapper.py 100.00% <ø> (ø)
spiceypy/spiceypy.py 99.69% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca3b8a...354bb60. Read the comment docs.

@AndrewAnnex AndrewAnnex merged commit f7b213e into main May 31, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants