Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix nested entity references #1

Merged

Conversation

saschatimme
Copy link
Contributor

@saschatimme saschatimme commented Jan 16, 2024

This fixes a bug with nested entity references where nested migrations would be dropped.

I think the easiest is to just check the added test case.

Without my fix my test example

{ 
   v: 1,
   c: 4,
   child: {
        v: 1,
        a: 8,
      }
}

would have been migrated to

{ 
   v: 2,
   d: 4,
   child: {
        v: 1,
        a: 8,
      }
}

instead of

{ 
   v: 2,
   d: 4,
   child: {
        v: 2,
        b: 8,
      }
}

sorry for the noisy diff, I don't know which prettier config you use. Maybe you can format the PR?

@AndrewBastin
Copy link
Owner

Crap, missed this in the Inbox. Will have a look over the weekend @saschatimme 🙇

Copy link
Owner

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants