Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

🐛 Convert the command name in lowercase #16

Merged
merged 3 commits into from
Jun 16, 2021

Conversation

imyanice
Copy link
Contributor

@imyanice imyanice commented Jun 16, 2021

This PR will add a verification if the name is Uppercased.
Sorry the GIF is ugly and I don’t show you it but you can test the website here: https://slash-command-gui.netlify.app/ (it is the same url without the ‘s’ at command)
Video example

@Androz2091 Androz2091 self-requested a review June 16, 2021 12:23
@imyanice imyanice changed the title ✅ Check if the command name is Uppercased ✅ Convert the command name in lowercase Jun 16, 2021
@imyanice imyanice marked this pull request as ready for review June 16, 2021 12:53
@imyanice
Copy link
Contributor Author

@Androz2091 Ready if you want

Copy link
Owner

@Androz2091 Androz2091 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 👍

@Androz2091 Androz2091 changed the title ✅ Convert the command name in lowercase 🐛 Convert the command name in lowercase Jun 16, 2021
@Androz2091 Androz2091 merged commit 2f311c4 into Androz2091:main Jun 16, 2021
@imyanice imyanice changed the title 🐛 Convert the command name in lowercase 🐛 Convert the command name in lowercase Jun 16, 2021
@imyanice
Copy link
Contributor Author

Thank you for your contribution 👍

@Androz2091 you're welcome 😉 !

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants