add slash

AnswerDotAI · Nov 16, 2020 · 0ff4a33 · 0ff4a33
1 parent d5e0e37
commit 0ff4a33
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/fastcore/xtras.py b/fastcore/xtras.py
@@ -186,7 +186,7 @@ def urlquote(url):
     "Update url's path with `urllib.parse.quote`"
     subdelims = "!$&'()*+,;="
     gendelims = ":?#[]@"
-    safe = subdelims+gendelims+"%"
+    safe = subdelims+gendelims+"%/"
     p = list(urlparse(url))
     p[2] = urllib.parse.quote(p[2], safe=safe)
     for i in range(3,6): p[i] = urllib.parse.quote(p[i], safe=safe)

diff --git a/nbs/03_xtras.ipynb b/nbs/03_xtras.ipynb
@@ -588,7 +588,7 @@
     {
      "data": {
       "text/plain": [
-       "['e', 'c', 'h', 'a', 'f', 'g', 'b', 'd']"
+       "['e', 'g', 'a', 'd', 'c', 'b', 'f', 'h']"
       ]
      },
      "execution_count": null,
@@ -1168,7 +1168,7 @@
     "    \"Update url's path with `urllib.parse.quote`\"\n",
     "    subdelims = \"!$&'()*+,;=\"\n",
     "    gendelims = \":?#[]@\"\n",
-    "    safe = subdelims+gendelims+\"%\"\n",
+    "    safe = subdelims+gendelims+\"%/\"\n",
     "    p = list(urlparse(url))\n",
     "    p[2] = urllib.parse.quote(p[2], safe=safe)\n",
     "    for i in range(3,6): p[i] = urllib.parse.quote(p[i], safe=safe)\n",
@@ -1183,7 +1183,7 @@
     {
      "data": {
       "text/plain": [
-       "'https://github.com/%2Ffastai%2Ffastai%2Fcompare%2Fmaster@%7B1.day.ago%7D%E2%80%A6master'"
+       "'https://github.com/fastai/fastai/compare/master@%7B1.day.ago%7D%E2%80%A6master'"
       ]
      },
      "execution_count": null,
@@ -1203,7 +1203,7 @@
     {
      "data": {
       "text/plain": [
-       "'https://www.google.com/%2Fsearch?q=%E4%BD%A0%E5%A5%BD'"
+       "'https://www.google.com/search?q=%E4%BD%A0%E5%A5%BD'"
       ]
      },
      "execution_count": null,