Skip to content

update db #105

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 20, 2023
Merged

update db #105

merged 6 commits into from
Jan 20, 2023

Conversation

schiltz3
Copy link
Collaborator

@schiltz3 schiltz3 commented Jan 20, 2023 •
edited
Loading

Work on updateDB

Changes

  • Break out cleanCourseCode to a separate function and generalize it for other courses
  • Break out removeHTML to a separate function and only use it in getCoursesWithDescription
  • Handle duplicates
  • Batch db saves together to reduce db operations by using bulkSave

@schiltz3 schiltz3 requested a review from nathen418 January 20, 2023 22:24
@schiltz3 schiltz3 self-assigned this Jan 20, 2023
nathen418
nathen418 approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@nathen418 nathen418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool cool I like it

@nathen418 nathen418 merged commit e6b8264 into feature/nathen418/populate-db-from-api Jan 20, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nathen418 nathen418 nathen418 approved these changes

Assignees

@schiltz3 schiltz3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schiltz3 @nathen418