This repository has been archived by the owner on Jan 19, 2024. It is now read-only.
Massive Set of Changes #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 27 commits
March 6, 2023 17:20
…proj into larryk85/proj-changes
larryk85
requested review from
ScottBailey and
mikelik
and removed request for
ScottBailey
9 tasks
Unimportant for now. |
dimas1185
reviewed
Apr 4, 2023
| @@ -32,9 +32,9 @@ endif() | |||
| # | |||
| # NOTE: This is used due to legacy requirements instead of: | |||
| # `install(FILE <license files> COMPONENT Documentation DESTINATION share/aproj/licenses)` | |||
| configure_file(LICENSE ${CMAKE_CURRENT_BINARY_DIR}/licenses/LICENSE COPYONLY) | |||
| configure_file(LICENSE licenses/LICENSE COPYONLY) | |||
There was a problem hiding this comment.
I may change this back in cdt/#112 if submoduling won't work with this
There was a problem hiding this comment.
Hmm, you might need to change it to something different. The replacement line and original should be functionally the same.
dimas1185
approved these changes
Apr 4, 2023
ScottBailey
approved these changes
Apr 4, 2023
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apologize in advance for the review.
For playing around with this look at https://github.com/larryk85/antler-proj-foo, this should have a reasonably complex project that you can build and populate.