Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix ABI generator to correctly handle tables from other contracts #200

Closed

Conversation

aamirpashaa
Copy link

@aamirpashaa aamirpashaa commented Jul 17, 2023

Fixes #198

Change Description

There was a problem in the ABI generator that added included singleton table structs from other contracts (included using header import or with eosio::contract tag) to the ABI, which was not intended. This PR fixes this problem, and the appropriate test case with the desired ABI has also been added.

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@aamirpashaa aamirpashaa changed the title fix ABI generator to correctly handle tables from other contracts and… Fix ABI generator to correctly handle tables from other contracts Jul 17, 2023
@dimas1185
Copy link
Contributor

note that your solution doesn't handle case when singleton will have non-table type and be defined in other contract.
here is solution that handles all cases I can think of:
#201

@ericpassmore ericpassmore self-requested a review July 18, 2023 18:24
@ericpassmore
Copy link
Contributor

Thanks for the contribution. Our engineering met and decided we wanted a fuller solution that optimized the ABI and worked on a class level. You can review and contribute to our work in PR #201 The solution posted here adds additional abi that may not be needed by the contract. For that reason we are closing this PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct target for Type in ABI
3 participants