#159: Differentiate Between BaseUser and User #288
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Differentiate between BaseUser and User by creating a Base class for all users and a User class that implements it, just like Artist is doing it at the moment.
Commit type
refactor
: refactoring production code, eg. renaming a variable.Issue
#159
Solution
The solution involves restructuring the User class hierarchy by creating a new
BaseUser
class to serve as a common base for all user types. The User class now extends BaseUser, aligning with the existing structure of the Artist class.Proposed Changes
-created BaseUser
-modified User to inherit from BaseUser
-changed type annotations from User to BaseUser
Potential Impact
This change could affect any existing functionality that directly references the User class. Potential risks include compatibility issues in methods expecting a User instance but now receiving BaseUser. Careful testing and updates to type annotations will be essential to minimize side effects.
Additional Tasks
Assigned
@AntonioMrtz