fix(qq): 🐛 fix websocket connection with invalid path

AnzhiZhang · Oct 2, 2024 · 92d7208 · 92d7208
1 parent c11e134
commit 92d7208
Showing 1 changed file with 17 additions and 3 deletions.
diff --git a/src/main/java/com/zhanganzhi/chathub/platforms/qq/protocol/QQWsServer.java b/src/main/java/com/zhanganzhi/chathub/platforms/qq/protocol/QQWsServer.java
@@ -32,15 +32,29 @@ public QQWsServer(String host, Integer port, String validResourcePath, Queue<QQE
 
     @Override
     public void onOpen(WebSocket webSocket, ClientHandshake clientHandshake) {
-        logger.info("QQ WebSocket connection opened at [{}], path:[{}]", webSocket.getLocalSocketAddress(), clientHandshake.getResourceDescriptor());
-        if (validResourcePath.equals(clientHandshake.getResourceDescriptor())) {
+        InetSocketAddress remoteSocketAddress = webSocket.getRemoteSocketAddress();
+        String resourceDescriptor = webSocket.getResourceDescriptor();
+        if (validResourcePath.equals(resourceDescriptor)) {
             clients.add(webSocket);
+            logger.info(
+                    "QQ WebSocket client at [{}] connection established with path [{}]",
+                    remoteSocketAddress,
+                    resourceDescriptor
+            );
+        } else {
+            webSocket.close();
+            logger.warn(
+                    "QQ WebSocket client at [{}] connection established with invalid path [{}], connection closed",
+                    remoteSocketAddress,
+                    resourceDescriptor
+            );
         }
     }
 
     @Override
     public void onClose(WebSocket webSocket, int i, String s, boolean b) {
-        logger.info("QQ WebSocket connection closed");
+        logger.info("QQ WebSocket client at [{}] connection closed", webSocket.getRemoteSocketAddress());
+        clients.remove(webSocket);
     }
 
     @Override