Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add oidc scope configuration option #5926

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Add oidc scope configuration option #5926

merged 1 commit into from
Jan 28, 2025

Conversation

carlesarnal
Copy link
Member

No description provided.

@apicurio-bot
Copy link

apicurio-bot bot commented Jan 28, 2025

Thank you for creating a pull request!

Pinging @EricWittmann to respond or triage.

@apicurio-bot apicurio-bot bot added the area/ui label Jan 28, 2025
@carlesarnal carlesarnal added port-3.x Port from 2.x to 3.x and removed area/ui labels Jan 28, 2025
@carlesarnal carlesarnal modified the milestones: 3.0.7, 2.6.x Jan 28, 2025
EricWittmann
EricWittmann approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@EricWittmann EricWittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but how does this fix the recent problem with 2.6.7?

@EricWittmann EricWittmann merged commit c614964 into Apicurio:2.6.x Jan 28, 2025
19 checks passed
@carlesarnal
Copy link
Member Author

LGTM but how does this fix the recent problem with 2.6.7?

https://github.com/Apicurio/apicurio-registry/pull/5371/files#diff-144cc22e098ff9d7ee6b79ad7458306be98fd850a58c499a851d2bb30dbe812eL185 this changed oidc auth to use the access_token (which is right) but, for that to work in Entra ID, the scope has to include the client id so that it's added to the aud claim, so that when the backend validates it, it has been issued for the correct audience. It's a whole chain to have the expected aud claim when access_tokens are used.

@bf2robot bf2robot mentioned this pull request Jan 31, 2025
Open
1 task
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@EricWittmann EricWittmann EricWittmann approved these changes

Assignees
No one assigned
Labels
port-3.x Port from 2.x to 3.x
Projects
Registry 3.0
Status: Done
Milestone
3.0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@carlesarnal @EricWittmann