Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Retry strategy ShouldHandle in example code #2527

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marcrocny
Copy link

Pull Request

The issue or feature being addressed

The existing example compiles, but incorrectly shows the ShouldHandle delegate as operating on an Exception object.

Details on the issue fix or feature implementation

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • N/A, doc only I have included unit tests for the issue/feature
  • N/A, doc only I have successfully run a local build

@marcrocny
Copy link
Author

@dotnet-policy-service agree

@martincostello
Copy link
Member

Thanks for the PR.

You'll need to change the code in the Snippets, which are used to generate the docs, otherwise the changes will get overwritten.

Once you've done that the docs can be regenerated with:

dotnet tool restore
dotnet mdsnippets

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants