Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add new default shortcuts for exisiting handlers v1 #1786

Merged
merged 2 commits into from
Feb 3, 2023
Merged

feat: add new default shortcuts for exisiting handlers v1 #1786

merged 2 commits into from
Feb 3, 2023

Conversation

MayurSMahajan
Copy link
Collaborator

Solves #1760 , partially

Adds the following shortcuts:

  • Shift+Home
  • Shift+End
  • Ctrl/Meta + Y

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2023

Codecov Report

Merging #1786 (d9c9cc3) into main (2e91dfb) will increase coverage by 41.26%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##             main    #1786       +/-   ##
===========================================
+ Coverage   37.88%   79.15%   +41.26%     
===========================================
  Files         419      120      -299     
  Lines       19745     6803    -12942     
===========================================
- Hits         7481     5385     -2096     
+ Misses      12264     1418    -10846     
Flag Coverage Δ
appflowy ?
appflowy_editor 79.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rvice/shortcut_event/built_in_shortcut_events.dart 97.97% <ø> (ø)
frontend/app_flowy/lib/plugins/trash/trash.dart
...lowy/lib/workspace/application/view/view_bloc.dart
...d/app_flowy/lib/user/application/sign_in_bloc.dart
...wy/lib/workspace/presentation/home/home_sizes.dart
frontend/app_flowy/lib/startup/tasks/rust_sdk.dart
...owy/lib/workspace/presentation/home/menu/menu.dart
...e/presentation/settings/widgets/settings_menu.dart
...board/application/card/board_number_cell_bloc.dart
.../lib/workspace/application/view/view_listener.dart
... and 290 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@LucasXu0 LucasXu0 merged commit 70e8b2e into AppFlowy-IO:main Feb 3, 2023
@MayurSMahajan MayurSMahajan deleted the fr_default_shortcuts_1760 branch February 3, 2023 06:01
zoli pushed a commit to LucasXu0/AppFlowy that referenced this pull request Aug 30, 2023
…O#1786)

* feat: add new default shortcuts v1

* refactor: remove unnecessary space
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants