-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: Add server status validation #40
Merged
saikrishna321
merged 8 commits into
AppiumTestDistribution:main
from
mykola-mokhnach:status
Jul 10, 2024
Merged
chore: Add server status validation #40
saikrishna321
merged 8 commits into
AppiumTestDistribution:main
from
mykola-mokhnach:status
Jul 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudharsan-selvaraj
requested changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall changes looks good. The error message is clean and neat👍
github-actions bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
## 1.0.0 (2024-07-10) ### Bug Fixes * Respect adb settings provided to the driver ([#19](#19)) ([e3a0148](e3a0148)) ### Miscellaneous Chores * Add server status validation ([#40](#40)) ([20299df](20299df)) * setup semantic release ([#41](#41)) ([10a00cb](10a00cb)) * Use logger attached to the driver instance where possible ([#33](#33)) ([639aef8](639aef8))
🎉 This issue has been resolved in version 1.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would properly short-circuit if the server returns an unexpected status and also improves user-facing massages.