Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PS-10] Créer une page de connexion WEB #1

Merged
merged 5 commits into from
Jan 23, 2024
Merged

[PS-10] Créer une page de connexion WEB #1

merged 5 commits into from
Jan 23, 2024

Conversation

HugoMigner
Copy link
Contributor

@HugoMigner HugoMigner commented Jan 22, 2024 •
edited
Loading

Add the login page with basic components (Checkbox, PasswordInput, etc)

Also includes basic project setup files (.eslintrc.js, .tailwind.config.js, etc)

Screenshots 🖼️

image

Udito3
Udito3 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@Udito3 Udito3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camillebrulotte
Copy link
Contributor

@HugoMigner Est-ce que tu pourrais mettre des screenshots sil vous please ?

@camillebrulotte
Copy link
Contributor

Good job ! Des petits comments :

  1. Quand je dézoom ma page la boîte resize pas :
image
  1. Mettre les points un peu plus gros :
image
  1. Mettre le checkbox la même couleur que le texte à droite (C'est cool l'effet quand on click dessus) et mettre aussi le border de la même couleur pour qu'il puisse être visible :
image image
  1. Le texte underline doit être la même couleur que le bouton :
image
  1. Je viens de changer d'avis on écrit : Bienvenue ! (Point d'exclamation)
image
  1. Possible que la boîte de texte devient higlight quand elle est sélectionné comme dans la maquette ?
Capture d’écran, le 2024-01-22 à 13 54 18

camillebrulotte
camillebrulotte requested changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@camillebrulotte camillebrulotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques comments sinon good job !

@HugoMigner
Copy link
Contributor Author

Corrections: @camillebrulotte

Dezoom ⬇️

image

Points placeholder, checkbox et input border ⬇️

image

Text underline ⬇️ (comme ça?)

image

camillebrulotte
camillebrulotte approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@camillebrulotte camillebrulotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Udito3
Udito3 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@Udito3 Udito3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HugoMigner HugoMigner merged commit 3d128dc into main Jan 23, 2024
1 check passed
@HugoMigner HugoMigner deleted the feature/#-page branch January 23, 2024 02:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@camillebrulotte camillebrulotte camillebrulotte approved these changes

@Udito3 Udito3 Udito3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HugoMigner @camillebrulotte @Udito3