Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

horizon: use keyword arg for radius #1302

Merged

Conversation

srmainwaring
Copy link
Contributor

@srmainwaring srmainwaring commented Jan 4, 2024

Fixes: #1271

The matplotlib.patches.RegularPolygon initialiser requires a keyword arg rather than positional arg for the radius:

https://github.com/matplotlib/matplotlib/blob/39582424f8ce5e042e4e39eeac94893f222c9f8b/lib/matplotlib/patches.py#L895-L897

Tested with matplotlib==3.7.4 for backwards compatibility and matplotlib==3.8.2.

- Required in matplotlib==3.8.0 and later.

Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
@peterbarker peterbarker merged commit ef4f77a into ArduPilot:master Jan 4, 2024
@peterbarker
Copy link
Contributor

Merged, thanks!

@srmainwaring srmainwaring deleted the prs/pr-horizon-regpolygon-args branch January 5, 2024 12:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizon module crashes with RegularPolygon.__init__() takes 3 positional arguments but 4 were given
2 participants