NTRIP: use pynmeagps for correct gga generation #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @richahert, Could you rebase this on master to remove the merge commits? |
richahert
force-pushed
the
pynmeagps-no-formatting
branch
from
1a5ec63 to
3ee425c
Compare
|
Hi @rmackay9 , |
|
Hi @richahert, Thanks for that. You might want to also prefix the commit message with "ntrip:" or "NTRIP:" to be consistent with other commits in this repo but again, I'm not a maintainer so this is just a suggestion and I'm not sure how strict Tridge and others are. If this gets stuck and not merged then it might need to be brought up on one of the dev calls to get merged. The best choice is probably the small EU Dev Call which is later today. |
tridge
approved these changes
Feb 28, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MAVproxy NTRIP client does not work with several NTRIP casters, because the GGA messages are sent in an incompatible format. this is described in #1131
This PR solves that problem, by using the same library for gga generation that pygpsclient uses (pynmeagps), which I experienced to be working with all casters.
The ntrip client of pygpsclient works quite well, so I might open an Issue in the future to request that the MAVproxy ntrip could be refactored as a wraper of that NTRIP client. It has more active developers than the built-in NTRIP Client of MAVproxy.
For now, this PR should provide a solution that is tested with skylark and I am confident that it also solves the problem with topcon, but I can't test it atm, because I don't have an active subscription.