Generator: python: set display bitmask based on enum if no value is provided directly #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamPete1
force-pushed
the
python_generator_bitmask
branch
from
a1d2888 to
9cb9240
Compare
|
This is the diff in generated output.
|
tridge
approved these changes
Feb 24, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because enums are represented as lists with no class it would be a big change to add the bitmask property to the enum. Instead this sets the existing display property on the field which uses the enum to "bitmask" if no value is directly provided and the enum is marked as a bitmask in the xml.
mavlink/mavlink#2215
ArduPilot/mavlink#383
As far as I can tell the other generators deal with this correctly already.