Fix mavutil.mavtcpin not closing the accept()ed port on close() #760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
mavutil.mavtcpin
may leave theaccept()
ed port open after closing, leading toResourceWarning
s like this one:pymavlink 2.4.37 on both Windows and Linux (x86_64) and Python 3.10.
This MR fixes it. Also there's an unrelated
set_close_on_exec
docstring typo fix.