Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Further bugfixes and documentation fixes #338

Merged
merged 19 commits into from
Jan 17, 2023

Conversation

ianfixes
Copy link
Collaborator

@ianfixes ianfixes commented Dec 28, 2022

@ianfixes
Copy link
Collaborator Author

I will need to address #339 in this PR.

@hlovdal
Copy link
Contributor

hlovdal commented Dec 29, 2022

#339 should be fixed by my 2021-02-15_rescue.updates branch. It is now rebased on top of ianfixes/2022-12-28_tweaks.

Feel free to just add my fork as a remote and merge it into your branch, or do you want me to create a pull request?

@ianfixes
Copy link
Collaborator Author

@hlovdal disregard my other message on your closed PR, I will cherry pick your changes into this branch

@ianfixes ianfixes force-pushed the 2022-12-28_tweaks branch 2 times, most recently from 3e698f9 to 4baaec3 Compare December 31, 2022 17:05
ianfixes and others added 3 commits December 31, 2022 12:06
Running

    $HOME/arduino-cli --format json core install adafruit:avr --additional-urls https://adafruit.github.io/arduino-board-index/package_adafruit_index.json

for the first time fails with error message

    Error initializing instance: Loading index file: loading json index file $HOME/.arduino15/package_adafruit_index.json: open $HOME/.arduino15/package_adafruit_index.json: no such file or directory
    Error initializing instance: Loading index file: loading json index file $HOME/.arduino15/package_adafruit_index.json: open $HOME/.arduino15/package_adafruit_index.json: no such file or directory
    Invalid argument passed: Found 0 platform for reference "adafruit:avr":

However by running an update-index command first, then it succeeds, e.g.

    $HOME/arduino-cli --format json core update-index --additional-urls https://adafruit.github.io/arduino-board-index/package_adafruit_index.json
    $HOME/arduino-cli --format json core install adafruit:avr --additional-urls https://adafruit.github.io/arduino-board-index/package_adafruit_index.json

https://arduino.github.io/arduino-cli/0.29/getting-started/#adding-3rd-party-cores
@ianfixes ianfixes changed the title Minor bugfixes and documentation fixes Further bugfixes and documentation fixes Dec 31, 2022
@ianfixes ianfixes added this to the 2021 Beta 1 Features milestone Dec 31, 2022
@ianfixes ianfixes force-pushed the 2022-12-28_tweaks branch 2 times, most recently from 12cb8f9 to cd93245 Compare January 2, 2023 03:42
@ianfixes
Copy link
Collaborator Author

ianfixes commented Jan 9, 2023

I believe this verifies the fix for #339 -- fixing the problem that @RobTillaart was seeing:
https://github.com/ianfixes/FRAM_I2C/actions/runs/3876505881/jobs/6610424853

@RobTillaart
Copy link

The PR looks good to me so if there are no other showstoppers please merge and add a tag!
👍

@ianfixes ianfixes merged commit e699436 into Arduino-CI:master Jan 17, 2023
@ianfixes
Copy link
Collaborator Author

Sorry for the delay, this has been released as v1.5.0

# for free to join this conversation on GitHub. Already have an account? # to comment