feat: update world-cli to use CARDINAL_LOG_LEVEL env var #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “graphite/merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account in order to use the merge queue. # using this link. |
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
=======================================
Coverage 61.29% 61.29%
=======================================
Files 4 4
Lines 124 124
=======================================
Hits 76 76
Misses 45 45
Partials 3 3 ☔ View full report in Codecov by Sentry. |
zulkhair
force-pushed
the
daim/feat_update_world-cli_to_use_CARDINAL_LOG_LEVEL_env_var
branch
from
c0e7693
to
33cd094
Compare
zulkhair
commented
Jan 10, 2024
zulkhair
commented
Jan 10, 2024
zulkhair
force-pushed
the
daim/feat_update_world-cli_to_use_CARDINAL_LOG_LEVEL_env_var
branch
from
33cd094
to
6a7c735
Compare
zulkhair
requested review from
technicallyty and
a team
and removed request for
technicallyty
namrapatel
approved these changes
Jan 11, 2024
Merge activity
|
Closes: WORLD-681 Update world-cli to use CARDINAL_LOG_LEVEL env var Configuration can be added to world.toml or using flag --log-level on 'world cardinal start` command.
zulkhair
force-pushed
the
daim/feat_update_world-cli_to_use_CARDINAL_LOG_LEVEL_env_var
branch
from
6a7c735
to
598a34f
Compare
zulkhair
deleted the
daim/feat_update_world-cli_to_use_CARDINAL_LOG_LEVEL_env_var
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: WORLD-681
Update world-cli to use CARDINAL_LOG_LEVEL env var
Configuration can be added to world.toml or using flag --log-level on 'world cardinal start` command.