-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: run cadinal editor on dev mode #53
feat: run cadinal editor on dev mode #53
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “graphite/merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account in order to use the merge queue. # using this link. |
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
- Coverage 52.78% 52.53% -0.26%
==========================================
Files 9 9
Lines 629 632 +3
==========================================
Hits 332 332
- Misses 235 237 +2
- Partials 62 63 +1 ☔ View full report in Codecov by Sentry. |
d8442b2
to
5507569
Compare
Merge activity
|
Closes: WORLD-1000 ## Overview Add feature run cardinal on `world cardinal dev` ## Brief Changelog - add function to serve cardinal editor web files - add function to find unused port from 3000 to 4000 - add step to run cardinal editor before running redis and cardinal server (it will not block the process if cardinal editor failed to run) ## Testing and Verifying manually tested using `world cardinal dev` command   ## Todo This will be updated in the next PR - Check cardinal version to be match with cardinal server - Setup cardinal editor dir if not exists
5507569
to
9c1d1ca
Compare
Closes: WORLD-1000
Overview
Add feature run cardinal on
world cardinal dev
Brief Changelog
Testing and Verifying
manually tested using
world cardinal dev
commandTodo
This will be updated in the next PR