Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: run cadinal editor on dev mode #53

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

zulkhair
Copy link
Collaborator

@zulkhair zulkhair commented Apr 1, 2024

Closes: WORLD-1000

Overview

Add feature run cardinal on world cardinal dev

Brief Changelog

  • add function to serve cardinal editor web files
  • add function to find unused port from 3000 to 4000
  • add step to run cardinal editor before running redis and cardinal server (it will not block the process if cardinal editor failed to run)

Testing and Verifying

manually tested using world cardinal dev command

image.png

image.png

Todo

This will be updated in the next PR

  • Check cardinal version to be match with cardinal server
  • Setup cardinal editor dir if not exists

Copy link

graphite-app bot commented Apr 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “graphite/merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account in order to use the merge queue. # using this link.

Copy link

coderabbitai bot commented Apr 1, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Collaborator Author

zulkhair commented Apr 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @zulkhair and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 52.53%. Comparing base (c02b0c6) to head (5507569).

❗ Current head 5507569 differs from pull request most recent head 9c1d1ca. Consider uploading reports for the commit 9c1d1ca to get more accurate results

Files Patch % Lines
cmd/world/root/root.go 0.00% 2 Missing and 1 partial ⚠️
common/teacmd/editor.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   52.78%   52.53%   -0.26%     
==========================================
  Files           9        9              
  Lines         629      632       +3     
==========================================
  Hits          332      332              
- Misses        235      237       +2     
- Partials       62       63       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zulkhair zulkhair requested review from rmrt1n and smsunarto April 1, 2024 12:23
@zulkhair zulkhair marked this pull request as ready for review April 1, 2024 12:23
@zulkhair zulkhair requested review from jerargus and technicallyty and removed request for technicallyty and jerargus April 1, 2024 12:52
@zulkhair zulkhair force-pushed the daim/world-1000_run_cardinal_editor_in_dev_mode branch from d8442b2 to 5507569 Compare April 1, 2024 13:33
Copy link

graphite-app bot commented Apr 1, 2024

Merge activity

Closes: WORLD-1000

## Overview

Add feature run cardinal on `world cardinal dev`

## Brief Changelog
- add function to serve cardinal editor web files
- add function to find unused port from 3000 to 4000
- add step to run cardinal editor before running redis and cardinal server (it will not block the process if cardinal editor failed to run)

## Testing and Verifying

manually tested using `world cardinal dev` command

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/YO1Dcg4NByYdZHvKXaTq/d8464305-83c0-4190-8c52-e74a80668b83.png)

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/YO1Dcg4NByYdZHvKXaTq/06a3d01b-8821-441e-a8e7-e534fe5f3ef9.png)

## Todo
This will be updated in the next PR

- Check cardinal version to be match with cardinal server
- Setup cardinal editor dir if not exists
@zulkhair zulkhair force-pushed the daim/world-1000_run_cardinal_editor_in_dev_mode branch from 5507569 to 9c1d1ca Compare April 1, 2024 13:43
@graphite-app graphite-app bot merged commit 9c1d1ca into main Apr 1, 2024
5 checks passed
@zulkhair zulkhair deleted the daim/world-1000_run_cardinal_editor_in_dev_mode branch May 30, 2024 02:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants