-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: adjust closing file to make world cli run on windows #67
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
=======================================
Coverage 37.13% 37.13%
=======================================
Files 40 40
Lines 1764 1764
=======================================
Hits 655 655
Misses 982 982
Partials 127 127 ☔ View full report in Codecov by Sentry. |
Merge activity
|
Closes: WORLD-1149 ## Overview When trying to run world cli on windows, there's an issue when exec `world create`. This PR is adjusting the code for windows OS. ## Brief Changelog - Adjust file close to avoid Access Denied ## Testing and Verifying Manually tested on windows without using WSL
7483a60
to
8685e76
Compare
Closes: WORLD-1149
Overview
When trying to run world cli on windows, there's an issue when exec
world create
. This PR is adjusting the code for windows OS.Brief Changelog
Testing and Verifying
Manually tested on windows without using WSL