-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: re enable debug mode #69
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “graphite/merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. # using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8e8e2fc
to
bb3a8ae
Compare
bb3a8ae
to
1df124c
Compare
updated and tidied up the code. |
@zulkhair unit test is failing |
Yup, need to merge Argus-Labs/starter-game-template#51 first. |
1df124c
to
974df45
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
- Coverage 37.13% 36.89% -0.24%
==========================================
Files 40 40
Lines 1764 1740 -24
==========================================
- Hits 655 642 -13
+ Misses 982 973 -9
+ Partials 127 125 -2 ☔ View full report in Codecov by Sentry. |
0ebd5b7
to
95d328e
Compare
95d328e
to
a4b9120
Compare
Closes: WORLD-1154
Overview
Re enable debug mode with delve on
world cardinal start
with--debug
flagBrief Changelog
--debug
flagnakama-debug
container to fix nakama cannot run becausecardinal
is not runningTesting and Verifying
world cardinal start --debug
command and delve with vs codeNotes : Unit test failed because Argus-Labs/starter-game-template#51 need to be merged first and create new tag