Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: speed up agent arrangement #121

Merged
merged 3 commits into from
Jun 6, 2022
Merged

Conversation

LingweiMeng
Copy link
Contributor

Abandoned the step of "Removing Agent", speed up by about 30%.

@Konano
Copy link
Member

Konano commented Jun 6, 2022

Missing image resources?

@LingweiMeng
Copy link
Contributor Author

Missing image resources?

Nope. agent_resting.png and arrange_clean.png are already in the resources folder.

@Konano
Copy link
Member

Konano commented Jun 6, 2022

如果一楼宿舍计划进驻的干员正在二楼工作,并且此时处于未被撤下且心情未归 0,那么在新的策略下好像是会触发「是否撤下正在工作的干员」的弹窗?

或许可以两种策略都保留,默认老策略,新设一个参数决定是否加速?

@Konano
Copy link
Member

Konano commented Jun 6, 2022

哦等会好像加了强制确认的逻辑……我再想想会不会有其他 corner case……

Copy link
Member

@Konano Konano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Konano Konano merged commit 2f80186 into ArkMowers:dev Jun 6, 2022
@LingweiMeng
Copy link
Contributor Author

lgtm

Thanks for approving. 😉

@LingweiMeng LingweiMeng deleted the dev_base branch June 6, 2022 18:11
Konano pushed a commit that referenced this pull request Jun 8, 2022
* fix: improve robustness of agent arrangement

issued #121
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants