Add FlickeringText GetReportString null handler #223
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a base-game issue where exceptions thrown in
DisplayModule.Draw
could crash the game to desktop, if the Main Menu was bypassed (e.g. by launching an exception with-extstart
).To reproduce the original issue:
Missions/EmptyDirectory
directory.connect err::mls_nosvc
)This crashes because
DisplayModule.Draw
callsUtils.SendThreadedErrorReport
after 3 draw errors, launches a new thread to runUtils.SendErrorEmail
.While building up the email body, that method calls
FlickeringTextEffect.GetReportString
, which accessesFlickeringTextEffect.LinedItemTarget.IsDisposed
.If the Main Menu has not been rendered in the current game process execution,
FlickeringTextEffect.LinedItemTarget
isnull
, causing a crash.Example Broken Node: