Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Underline implementation #49

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

sahilverma-dev
Copy link
Contributor

Underline implementation

Description: This PR implements underline formatting in the Minimal Tiptap Editor using the Tiptap underline extension.

Changes:

  • Added underline functionality and button to the toolbar.
  • Ensured compatibility with existing formatting options.

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shadcn-tiptap ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 0:50am

@Aslam97
Copy link
Owner

Aslam97 commented Oct 31, 2024

@sahilverma-dev Thanks for the PR!

@Aslam97
Copy link
Owner

Aslam97 commented Oct 31, 2024

@sahilverma-dev LGTM!

@Aslam97 Aslam97 merged commit f86a2dc into Aslam97:main Oct 31, 2024
2 checks passed
@sahilverma-dev
Copy link
Contributor Author

@Aslam97, thanks for merging this PR! You might want to update the README file, as I completely forgot that it includes a list of extensions for installation.

@Aslam97
Copy link
Owner

Aslam97 commented Oct 31, 2024

@sahilverma-dev No worries! The doc isn't up to date at the moment. But, feel free to submit another PR with your changes.

@sahilverma-dev
Copy link
Contributor Author

@sahilverma-dev No worries! The doc isn't up to date at the moment. But, feel free to submit another PR with your changes.

Sure

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants