Skip to content

chore: update dependencies #2907

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Conversation

mattjohnsonpint
Copy link
Contributor

@mattjohnsonpint mattjohnsonpint commented Feb 6, 2025

Changes proposed in this pull request:

  • Update minimum Node and NPM versions (Node 16 is EOL)
  • Update all dependencies to latest version that build and pass tests without significant code changes
  • npm audit fix for two ReDoS patches (lockfile only, on cross-spawn and micromatch)
  • Fixed one minor warning about the order of types in package.json, which was seen after updating esbuild to latest
  • Updated GitHub Actions to latest versions
  • Removed code that was installing npm v6 because the linked bug was fixed some time ago.

I reviewed the change logs for these packages, and I think they should be ok.

I was not able to update binaryen without build/test failures. I'll look into this separately if I can find some time.

I know how to update eslint and typescript-eslint to latest, but it will be a bit involved and so it should be in a separate PR.

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@mattjohnsonpint mattjohnsonpint marked this pull request as draft February 6, 2025 02:33
@mattjohnsonpint

This comment was marked as outdated.

@mattjohnsonpint mattjohnsonpint marked this pull request as ready for review February 6, 2025 02:39
Copy link
Member

@HerrCai0907 HerrCai0907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HerrCai0907 HerrCai0907 merged commit cdd5e01 into AssemblyScript:main Feb 6, 2025
15 checks passed
@mattjohnsonpint mattjohnsonpint deleted the deps branch February 6, 2025 15:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants