Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Changed Figure names #461 issue #675

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marofmar
Copy link
Contributor

Figure Number Issue in 14-1.md
#461

Figure 5 -> Figure 19, Figure 6 -> Figure 20
So, the figure numbering goes like 4->19->20->7 and so forth.
Please enlighten me if I misunderstood your comments! @Atcold

Figure Number Issue in 14-1.md 
Atcold#461

Figure 5 -> Figure 19, Figure 6 -> Figure 20
So, the figure numbering goes like 4->19->20->7 and so forth.
Please enlighten me if I misunderstood your comments! @Atcold
@marcozullich
Copy link
Contributor

marcozullich commented Nov 9, 2020

Actually, it should be the other way round.

The figures should follow a numerical progression, so you should have -- and the image captions were correct before -- Fig. 4, 5, 6, and so on.

The issues were that:

  1. in the textual description of the documents, the Figure referenced the image's name (e.g., Fig. 5 was incorrectly referenced as Fig. 20)
  2. figures were missing a caption beside the figure name itself (in all other documents, figures have a textual description along with the figure number).

For now let's correct 1.; 2. will be corrected with another PR which I can handle since I'm waiting for the resolution of this problem to push the Italian translation of 14.1; it's not a huge work for me to put some captions in IT on the figures and then translate them in EN.

@Atcold
Copy link
Owner

Atcold commented Nov 25, 2020

Any update here?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants