Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(store): support resetting consume offset #434

Merged
merged 2 commits into from
Oct 26, 2023
Merged

feat(store): support resetting consume offset #434

merged 2 commits into from
Oct 26, 2023

Conversation

TheR1sing3un
Copy link
Contributor

  1. support resetting consume offsetcch

@TheR1sing3un
feat(store): support reset consume offset for pop mode
a5ca462 
1. support reset consume offset for pop mode

Signed-off-by: TheR1sing3un <ther1sing3un@163.com>
@TheR1sing3un
test(store): add reset consume offset test
93410d5 
1. add reset consume offset test

Signed-off-by: TheR1sing3un <ther1sing3un@163.com>
@TheR1sing3un TheR1sing3un requested a review from daniel-y October 23, 2023 09:23
@codecov
Copy link

codecov bot commented Oct 23, 2023

The author of this PR, TheR1sing3un, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at support@codecov.io with any questions.

@github-actions
Copy link

Qodana for JVM

4 new problems were found

Inspection name Severity Problems
Stream API call chain can be simplified 🔶 Warning 2
Method is identical to its super method 🔶 Warning 1
Duplicated code fragment ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

ShadowySpirits
ShadowySpirits reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@ShadowySpirits ShadowySpirits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be willing to add a CLI command?

@ShadowySpirits
Copy link
Contributor

close #245

@ShadowySpirits ShadowySpirits linked an issue Oct 24, 2023 that may be closed by this pull request
Support reset consume offset #245
Closed
@TheR1sing3un
Copy link
Contributor Author

Would you be willing to add a CLI command?

Sure, I will support it later

@daniel-y daniel-y merged commit 176355e into main Oct 26, 2023
@daniel-y daniel-y deleted the feat_reset_offset branch October 26, 2023 02:36
@TheR1sing3un TheR1sing3un restored the feat_reset_offset branch November 3, 2023 02:14
@Chillax-0v0 Chillax-0v0 deleted the feat_reset_offset branch February 20, 2024 06:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ShadowySpirits ShadowySpirits ShadowySpirits left review comments

@daniel-y daniel-y daniel-y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support reset consume offset
3 participants
@TheR1sing3un @ShadowySpirits @daniel-y